per machine disable dhcp option: #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has Tink API changes needed for implementing the disableDHCP functionality. Signed-off-by: Jacob Weinstock <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
====================================
- Coverage 52% 51% -1%
====================================
Files 26 26
Lines 2152 2736 +584
====================================
+ Hits 1129 1409 +280
- Misses 986 1287 +301
- Partials 37 40 +3 ☔ View full report in Codecov by Sentry. |
If the Hardware object specifies that DHCP is disabled we don't respond to DHCP packets. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
disable-dhcp
branch
from
632bc4c to
16c3026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements the new Hardware object spec field for being able to disable DHCP on a per Hardware and per interface basis.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: