Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubernetes client creation for single namespace: #536

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

jacobweinstock
Copy link
Member

Description

Single namespace look ups weren't functioning properly. They function properly now.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Single namespace look ups weren't functioning properly.
They function properly now.

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock merged commit 87fde25 into tinkerbell:main Oct 15, 2024
3 checks passed
@jacobweinstock jacobweinstock deleted the k8s-client branch October 15, 2024 23:16
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 52%. Comparing base (2a58e52) to head (6f17387).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/smee/backend.go 0% 19 Missing ⚠️
Additional details and impacted files
@@         Coverage Diff         @@
##           main   #536   +/-   ##
===================================
  Coverage    52%    52%           
===================================
  Files        26     26           
  Lines      2157   2152    -5     
===================================
+ Hits       1124   1127    +3     
+ Misses      991    987    -4     
+ Partials     42     38    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant