Add trusted proxies back as optional: #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an existing use-case where a user doesn't use Smee for DHCP and interpolating the mac address into the URL for the auto.ipxe script is either not possible or very difficult in their DHCP server. For this reason, we will allow using trusted proxies (XFF). We will also fall back to checking for the source IP in a request if the MAC address is not found in the URL path. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
chrisdoherty4
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an existing use-case where a user doesn't use Smee for DHCP and interpolating the mac address into the URL for the auto.ipxe script is either not possible or very difficult in their DHCP server. This PR will allow using trusted proxies (XFF) as a fallback if the MAC address is not found in the URL path.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: