Ensure a 120 second 'provider timeout' with each bmclib client #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James W. Brinkerhoff <[email protected]>
splaspood
force-pushed
the
fs-1816-timeouts-like-woah-0
branch
from
a3e34d1 to
f58bee2
Compare
DoctorVin
approved these changes
Oct 10, 2024
nshalman
approved these changes
Oct 10, 2024
ofaurax
approved these changes
Oct 11, 2024
joelrebel
reviewed
Oct 11, 2024
| @@ -381,6 +385,9 @@ func (m Action) DeactivateSOL(ctx context.Context) error { | |||
| span.SetAttributes(attribute.String("bmc.host", host), attribute.String("bmc.username", user)) | |||
| m.SendStatusMessage("working on SOL session deactivation") | |||
|
|
|||
| ctx, cancel := context.WithTimeout(ctx, 120*time.Second) | |||
| defer cancel() | |||
|
|
|||
| opts := []bmclib.Option{ | |||
| bmclib.WithLogger(m.Log), | |||
| bmclib.WithPerProviderTimeout(common.BMCTimeoutFromCtx(ctx)), | |||
There was a problem hiding this comment.
To confirm - there is currently an option being passed in which sets a timeout for each of the providers, is this not working?
bmclib.WithPerProviderTimeout(common.BMCTimeoutFromCtx(ctx))
With the current change - if a provider takes too long on the connection it leaves no time for the others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It has recently been discovered that bmclib's handling of timeouts, combined with the multiple providers leads to a number of failed actions initiated by pbnj. This change increases the timeout to 120 seconds which is clearly far longer than a timeout needs to be in this instance.
Why is this needed
While troubleshooting this issue it was discovered that bmclib can take 20-30 seconds performing actions via redfish. This timeout increase is meant as a bandaid fix while we investigate the performance issue(s) in bmclib.