Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get systemeventlog support #162

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mattcburns
Copy link
Contributor

@mattcburns mattcburns commented Apr 4, 2024

Description

Add support for getting the system event log (sel) via grpc and command line.

client.go:
SystemEventLog - Returns a slice of SystemEventLogEntry with an opinionated format (ID, Timestamp, Description, Message)
SystemEventLogRaw - Returns a blob of text that is the raw response from the BMC. (Log)

Why is this needed

Implements functionality added to bmclib so that SEL events can be captured.

Fixes: #

How Has This Been Tested?

Tests are added and pass.

How are existing users impacted? What migration steps/scripts do we need?

No migrations.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • [NA] provided instructions on how to upgrade

…d and regenerated protobufs to reflect. Some tests to make codecov happy.

Signed-off-by: Matthew Burns <[email protected]>
@mattcburns mattcburns force-pushed the get-systemeventlog branch from d976a7a to 5d02146 Compare April 4, 2024 18:05
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 27.45098% with 37 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@1e47be6). Click here to learn what that means.

Files Patch % Lines
grpc/rpc/diagnostic.go 27.45% 37 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage        ?   74.82%           
=======================================
  Files           ?        9           
  Lines           ?      584           
  Branches        ?        0           
=======================================
  Hits            ?      437           
  Misses          ?      132           
  Partials        ?       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattcburns mattcburns marked this pull request as ready for review April 4, 2024 18:15
@mattcburns mattcburns changed the title DRAFT Add get systemeventlog support Add get systemeventlog support Apr 4, 2024
@jacobweinstock jacobweinstock requested a review from joelrebel July 1, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant