Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reduce number of receive buffers to resolve download hangs on Broadco…
…m NetXtreme NICs (#171) ## Description This resolves an issue where large file downloads will hang on Broadcom NetXtreme NICs. This issue was caused by commit [`059c4dc`](ipxe/ipxe@059c4dc) which changed how drivers are loaded by iPXE. [A fix](ipxe/ipxe#1023 (comment)) was identified in [this issue](ipxe/ipxe#1023) wherein the number of receive buffers (defined as `NUM_RX_BUFFERS` in `src/drivers/net/bnxt/bnxt.h`) is reduced from the default value of 8 to 2. ## Why is this needed This is required to fix an issue where downloading large files (e.g. a kernel or initial RAM filesystem) will hang on Broadcom devices. ## How Has This Been Tested? This change was tested by using the committed modifications, rebuilding the iPXE binaries[^1], and then rebuilding smee with the new iPXE images. [^1]: Commands used to rebuild binaries. <details><summary>Build Instructions</summary> <p> ```bash $ make binary/clean $ make extract-ipxe $ make binaries # In smee repository $ go mod edit -replace=github.com/tinkerbell/ipxedust /path/to/local/ipxedust ``` </p> </details> These changes were tested by attempting to boot HookOS via Tinkerbell on servers with Broadcom BCM957504-N425G and BCM957504-P425G NICs. ## How are existing users impacted? What migration steps/scripts do we need? Fixes a bug--no action required by end users. ## Checklist: - ~~[ ] updated the documentation and/or roadmap (if required)~~ N/A. - ~~[ ] added unit or e2e tests~~ No tests, only changes build script. - ~~[ ] provided instructions on how to upgrade~~ No specific upgrade instructions.
- Loading branch information