hook-mdev: better /dev/disk/by-id via custom mdev script for wwid parsing and fallbacks
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR (Hook
|
|
Still not good enough for my USB-connected disks. Those have wwid with some |
rpardini
force-pushed
the
somewhat-better-mdev-disk-by-id
branch
from
5ef1d10 to
c10fd8a
Compare
|
Force-pushed fixed version. I had made a gross mistake (hardcoded This makes most disk devices at least appear in disk/by-id, even if they most probably won't match systemd's udev nomenclature, at least we have 'some' id. Using /dev/sdb et al directly is a recipe for disaster. |
This PR (after fixes), qemuA different VM, using |
rpardini
changed the title
/dev/disk/by-id via custom mdev script & better by-label/uuid via util-linux/dev/disk/by-id via custom mdev script for wwid parsing and fallbacks
…s-literis) - original persistent-storage from upstream Alpine: - source https://gitlab.alpinelinux.org/alpine/mdev-conf/-/blob/master/persistent-storage?ref_type=heads - revision a21d1053dd5ca37538b0435d66c58a30cb273658 - this is being added as reference for future rebases; it will be shellfmt'ed and modified in later commits Signed-off-by: Ricardo Pardini <[email protected]>
… changes) - simple rename & shellfmt; separate commit for easy future rebasing Signed-off-by: Ricardo Pardini <[email protected]>
…der to produce /dev/disk/by-id entries by parsing `wwid`
- this is still not-even-close to systemd's udev, but should at least add _something_ to by-id when Alpine's mdev wouldn't
- if device reports model and serial, all was/is good;
- introduce:
- if model or serial missing, try parsing them from wwid;
- falls back to using the sanitized wwid as serial if parsing fails
- last resort: falls back to using 'noserial' as serial for devices that only have a model.
- also adds `util-linux` related apks, which brings a more capable `blkid`
- for context: https://gitlab.alpinelinux.org/alpine/mdev-conf/-/commits/master/?ref_type=HEADS
- add a log of logging, which you can see with `cat /var/log/mdev.log` on Hook's console
Signed-off-by: Ricardo Pardini <[email protected]>
jacobweinstock
force-pushed
the
somewhat-better-mdev-disk-by-id
branch
from
c10fd8a to
c361f85
Compare
jacobweinstock
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hook-mdev: add
persistent-storagescript from upstream Alpine (ipsis-literis)hook-mdev: rename to
persistent-storage.shand shellfmt it (no real changes)hook-mdev: add customized
persistent-storagescript which tries harder to produce /dev/disk/by-id entries by parsingwwidutil-linuxrelated apks, which brings a more capableblkidcat /var/log/mdev.logon Hook's console