Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ttys, fix device mounting issue in getty, add nerdctl #222

Merged
merged 2 commits into from
May 16, 2024

Conversation

jacobweinstock
Copy link
Member

Description

For some reason I was seeing issues with the 6.6 kernel and ttys when they are not explicitly set in the linuxkit yaml. Also with the 6.6 kernel, I was seeing issues with the ctr command and character encoding or something similar. I was getting a lot of weird character when using it. Moving to nerdctl resolves this issue. Nerdctl is also a lot more user friendly in general. Also, the getty container was getting permission denied issues when trying to mount devices. Explicitly adding a block devices to the linuxkit yaml resolved this.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

For some reason the 6.6 kernel has issues
with ttys when they are not explicitly set
in the linuxkit yaml.

Signed-off-by: Jacob Weinstock <[email protected]>
The ctr command with the 6.6 kernel was having
issues with character encoding or something.
I was getting a lot of weird character when using
it. Moving to nerdctl resolves this issue. Nerdctl
is also a lot more user friendly in general.

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock merged commit 9323116 into tinkerbell:main May 16, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant