Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mdev as a service: #200

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Conversation

jacobweinstock
Copy link
Member

@jacobweinstock jacobweinstock commented Feb 15, 2024

Description

Linuxkit seems to not set the proper permissions for files/devices in /dev. Adding mdev enables proper setting of the permissions for files/devices in /dev. This fix was driven by the incorrect permissions for /dev/null that cause some actions using ubuntu/debian images to failed to run the apt update command.

This also adds deterministic device naming via /dev/device/by-*.

Why is this needed

Fixes: #142
Fixes: #152

How Has This Been Tested?

Manually tested.

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

This allows mdev to properly set
the permissions for devices in /dev.
This fix was driven by the incorrect permissions
for /dev/null.

Signed-off-by: Jacob Weinstock <[email protected]>
The alpine pkg mdev-conf provides
what we need better than the custom
mdev.conf previously added.

Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Copy link
Member

@chrisdoherty4 chrisdoherty4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Feb 15, 2024
@mergify mergify bot merged commit ebc1804 into tinkerbell:main Feb 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
2 participants