Adding support for a poweroff watcher #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Executes /sbin/poweroff once /worker/poweroff is written to disk
|
Hey @jasonyates-thg, thanks for this PR. I am hesitant to add this in because we've talked about adding this functionality as a builtin in the tink worker/agent. Also, there is an alternative way to go about it via waitdaemon |
|
I agree with Jacob. I think we have sufficient workarounds and a good plan to provide builtins that'll solve the problem. Our builtins should follow the v1alpha2 API work that's ongoing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expands the existing reboot watcher to provide support to power off the host system. Executes /sbin/poweroff once /worker/poweroff is written to disk
Why is this needed
Fixes: (#189)
How Has This Been Tested?
I am unable to build hook locally so this is untested.
How are existing users impacted? What migration steps/scripts do we need?
No impact