Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor backend opts #302

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

chrisdoherty4
Copy link
Member

Reduce duplicate config data structures and open up all backend option to the Kubernetes backend by using the already available config data structure.

@chrisdoherty4 chrisdoherty4 marked this pull request as ready for review October 10, 2023 15:20
@chrisdoherty4 chrisdoherty4 added the ready-to-merge Signal to Mergify to merge the PR. label Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #302 (049170a) into main (67cbc9d) will decrease coverage by 6.66%.
The diff coverage is 0.00%.

❗ Current head 049170a differs from pull request most recent head c6caf59. Consider uploading reports for the commit c6caf59 to get more accurate results

@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
- Coverage   76.92%   70.27%   -6.66%     
==========================================
  Files          18       17       -1     
  Lines         429      407      -22     
==========================================
- Hits          330      286      -44     
- Misses         87      117      +30     
+ Partials       12        4       -8     
Files Coverage Δ
internal/backend/backend.go 53.57% <0.00%> (ø)
internal/backend/kubernetes/backend.go 44.00% <0.00%> (-17.00%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Reduce duplicate config data structures and open up all backend option
to the Kubernetes backend by using the already available config data
structure.

Signed-off-by: Chris Doherty <[email protected]>
@mergify mergify bot merged commit 2cc9850 into tinkerbell:main Oct 10, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants