Allow TinkerbellMachine to be removed when no Hardware exists: #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
orphan-machine
branch
from
ec0d2c2 to
57a9f2d
Compare
When a Hardware object corresponding to a tinkerbellmachine object no longer exists, allow the tinkerbellmachine object to be removed and clean up associated template and workflow. At the moment this will skip any BMC operations to power the machine off and modify the Hardware object. This allows the tinkerbellmachine to be deleted without needing to know that it's ok to remove the finalizer and delete the object manually. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
orphan-machine
branch
from
57a9f2d to
47ea01e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a Hardware object corresponding to a tinkerbellmachine object no longer exists, allow the tinkerbellmachine object to be removed and clean up associated template and workflow. This means BMC operations to power the machine off and modify the Hardware object will all be skipped.
While the tinkerbellmachine object can be deleted if the finalizer is removed manually this improves the user experience.
Why is this needed
Fixes: #368
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: