Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and push container image for all main line commits: #340

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

jacobweinstock
Copy link
Member

@jacobweinstock jacobweinstock commented Jan 18, 2024

Description

This will make available container images for all commits on main in between releases.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

This will make available container images for all
commits inbetween releases.

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Jan 18, 2024
@jacobweinstock jacobweinstock force-pushed the build-push-images-on-main branch from 75ec705 to c1de516 Compare January 18, 2024 01:05
This will speed up PR builds.

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock force-pushed the build-push-images-on-main branch from 3e0fa34 to fc7462d Compare January 18, 2024 01:17
Copy link
Member

@chrisdoherty4 chrisdoherty4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. I think long term we should decompose the image building like Tink and Hegel do so its a little easier to invoke locally. Tink and Hegel aren't perfect, but they go a good way to being local friendly.

@mergify mergify bot merged commit 274fbe2 into tinkerbell:main Jan 18, 2024
9 checks passed
@jacobweinstock jacobweinstock deleted the build-push-images-on-main branch January 18, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants