Add error handling for ISO boot mode: #924
jacobweinstockci.yaml
on: pull_request
Codespell
11s
Build and push manager image
1m 33s
Matrix: validate
Annotations
2 errors and 2 warnings
|
Validate lint:
controller/machine/workflow.go#L71
do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf(\"iso boot mode requires an isoURL\")" (err113)
|
|
Validate lint:
controller/machine/workflow.go#L73
assignments should only be cuddled with other assignments (wsl)
|
|
Build and push manager image
The following actions use a deprecated Node.js version and will be forced to run on node20: docker/metadata-action@9ec57ed1fcdbf14dcef7dfbe97b2010124a938b7. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
The 'as' keyword should match the case of the 'from' keyword:
Dockerfile#L17
FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
tinkerbell~cluster-api-provider-tinkerbell~7OY5WC.dockerbuild
|
40.3 KB |
|