Skip to content

Commit

Permalink
Fix loadBalancerIP value to match expected in service.yaml: (#12)
Browse files Browse the repository at this point in the history
## Description


This fixes the issue in the released chart version v0.1.0, where the `loadBalancerIP` is not being set for the stack service spec.

## Why is this needed


The released chart version v0.1.0 is broken. Stack service never gets a load balancer IP.

Fixes: #

## How Has This Been Tested?



Install the helm chart from `ghcr.io`.
```bash
 helm install oci://ghcr.io/tinkerbell/charts/stack stack-release --version 0.1.0 --create-namespace --namespace tink-system --wait --set "boots.boots.trustedProxies=${trusted_proxies}" --set "hegel.hegel.trustedProxies=${trusted_proxies}"
```
Observe that the `tink-stack` service doesn't get an `External-IP`.
```bash
NAMESPACE     NAME             TYPE           CLUSTER-IP      EXTERNAL-IP  PORT(S)                                          AGE
tink-system   tink-stack       LoadBalancer   10.43.113.46    <pending>  50061:30998/TCP,42113:30730/TCP,8080:32531/TCP 9m2s
```

## How are existing users impacted? What migration steps/scripts do we need?





## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
  • Loading branch information
mergify[bot] authored Oct 20, 2022
2 parents 047b2e8 + 79d72b0 commit 57801e9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tinkerbell/stack/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ stack:
type: LoadBalancer
selector:
app: tink-stack
loadbalancerIP: 192.168.2.111
loadBalancerIP: 192.168.2.111
lbClass: kube-vip.io/kube-vip-class
image: nginx:1.23.1
hook:
Expand Down

0 comments on commit 57801e9

Please sign in to comment.