Make sure to add non-default longtype to map field info for #260

CHANGELOG.md

@@ -1,5 +1,10 @@
 ### unreleased changes
 
+Bug fixes:
+
+- Make sure to add non-default longtype to map field info, see #260
+
+
 New Features:
 
 - Add option `eslint_disable`, which generates a comment /* eslint-disable */ at the

packages/plugin/src/code-gen/field-info-generator.ts

@@ -200,16 +200,18 @@ export class FieldInfoGenerator {
                 break;
             case "scalar":
                 T = this.createScalarType(mapV.T);
-                if (mapV.L)
+                if (mapV.L !== undefined)
                     L = this.createLongType(mapV.L);
                 break;
         }
-        let properties: ts.ObjectLiteralElementLike[] = [
+        const properties: ts.ObjectLiteralElementLike[] = [
             ts.createPropertyAssignment(ts.createIdentifier('kind'), ts.createStringLiteral(mapV.kind)),
             ts.createPropertyAssignment(ts.createIdentifier('T'), T)
         ];
         if (L) {
-            ts.createPropertyAssignment(ts.createIdentifier('L'), L)
+            properties.push(
+                ts.createPropertyAssignment(ts.createIdentifier('L'), L)
+            );
         }
         return ts.createObjectLiteral(properties);
     }

packages/test-fixtures/index.ts

@@ -1,7 +1,6 @@
 import msgOneofs from './msg-oneofs.fixtures'
 import msgScalar from './msg-scalar.fixtures'
 import msgEnum from './msg-enum.fixtures'
-import msgMaps from './msg-maps.fixtures'
 import msgJsonNames from './msg-json-names.fixtures'
 import msgProto2Optionals from './msg-proto2-optionals.fixtures'
 import msgProto3Optionals from './msg-proto3-optionals.fixtures'
@@ -551,7 +550,6 @@ export const fixtures = new FixtureRegistry();
 fixtures.register(msgOneofs);
 fixtures.register(msgScalar);
 fixtures.register(msgEnum);
-fixtures.register(msgMaps);
 fixtures.register(msgJsonNames);
 fixtures.register(msgProto2Optionals);
 fixtures.register(msgProto3Optionals);