Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize repo - Major codebase change #164

Merged
merged 13 commits into from
Feb 3, 2023
Merged

Organize repo - Major codebase change #164

merged 13 commits into from
Feb 3, 2023

Conversation

timiimit
Copy link
Owner

@timiimit timiimit commented Feb 3, 2023

This PR organizes repository. I don't expect anyone to look through the code.

The following was performed:

  • put related classes into same namespace and folder
  • separate the backend code into multiple project modules
  • at a couple of places Newtonsoft library was replaced with System.Text.Json which follows Use System.Text.Json across whole project #33
  • a couple more minor changes were made

c# code was split up because I was working on #26. I wrote a c# XMPP server which needs some knowledge of classes used in main master server and both will need to communicate directly (most likely over a simple tcp connection).

Before merging i still need to test whether everything is operational. When that's done, I will duplicate current master branch to another branch. This way it will be easier to see what this PR messed up if later down the line we discover something isn't working.

@timiimit
Copy link
Owner Author

timiimit commented Feb 3, 2023

Looks like everything is working. I will merge this after #162 is merged.

@Saibamen
Copy link
Collaborator

Saibamen commented Feb 3, 2023

I'm will not be available this weekend. Can you check if our paths (both trigger and ignore) in GH Actions need to be changed? Thanks

@timiimit timiimit marked this pull request as ready for review February 3, 2023 16:46
@timiimit timiimit merged commit c44b408 into master Feb 3, 2023
@timiimit timiimit deleted the organize-repo branch February 3, 2023 16:55
@timiimit
Copy link
Owner Author

timiimit commented Feb 3, 2023

As agreed with @belmirp I merged this before #162

@timiimit
Copy link
Owner Author

timiimit commented Feb 3, 2023

@Saibamen I think it looks fine as is, but I'm no expert.

Saibamen added a commit to Saibamen/UT4MasterServer that referenced this pull request Feb 5, 2023
@Saibamen Saibamen mentioned this pull request Feb 5, 2023
timiimit added a commit that referenced this pull request Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants