More backend admin panel functionality #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belmirp
reviewed
Jan 27, 2023
|
|
||
| var account = await accountService.GetAccountAsync(EpicID.FromString(id)); | ||
| if (account is null) | ||
| return NotFound(new ErrorResponse() { ErrorMessage = $"Failed to find account {id}" }); |
| return NotFound(new ErrorResponse() { ErrorMessage = $"Failed to find account {id}" }); | ||
|
|
||
| if (account.Flags.HasFlag(AccountFlags.Moderator) || account.Flags.HasFlag(AccountFlags.Admin)) | ||
| throw new UnauthorizedAccessException("Cannot change password of other admins or moderators"); |
| } | ||
|
|
||
| [HttpDelete("account/{id}")] | ||
| public async Task<IActionResult> DeleteAccountInfo(string id, [FromBody] bool? forceCheckBroken) |
There was a problem hiding this comment.
Same security consideration as in ChangePassword.
| } | ||
| else | ||
| { | ||
| if (admin.Account.Flags.HasFlag(AccountFlags.Admin) && account.Flags.HasFlag(AccountFlags.Admin)) |
|
|
||
| if (admin.Account.Flags.HasFlag(AccountFlags.Moderator) && | ||
| (account.Flags.HasFlag(AccountFlags.Admin) || account.Flags.HasFlag(AccountFlags.Moderator))) | ||
| throw new UnauthorizedAccessException("Cannot delete account of other admin or moderator"); |
| "nigger", "hitler", "nazi" | ||
| }; | ||
| } | ||
|
|
| @@ -23,15 +23,29 @@ public CloudStorageService(DatabaseContext dbContext) | |||
| cloudStorageCollection = dbContext.Database.GetCollection<CloudFile>("cloudstorage"); | |||
| } | |||
|
|
|||
| public async Task UpdateSystemfiles() | |||
| public async Task EnsureSystemfilesExistAsync() | |||
There was a problem hiding this comment.
i remember from ut's source that epic calls files in cloud storage Userfiles and Systemfiles with lowercase letters for file. that is why i had across whole codebase originally these with lowercase. i guess i can make them upper... Should also change all other instances of this too. as well as our code filenames.
There was a problem hiding this comment.
If it doesn't brake functionality of the game client, then it is better to change it everywhere because it was clearly non-conventional naming.
|
Related: #135 |
belmirp
approved these changes
Jan 29, 2023
timiimit
added a commit
that referenced
this pull request
Jan 30, 2023
Fix runtime exception introduced by #148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidationHelper