Dev #18
Merged
Dev #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ftovers to next auction
…were added as leftovers to next auction
bekauz
reviewed
Feb 22, 2024
bekauz
approved these changes
Feb 22, 2024
uditvira
reviewed
Feb 22, 2024
uditvira
reviewed
Feb 22, 2024
uditvira
reviewed
Feb 22, 2024
| } | ||
|
|
||
| #[cw_serde] | ||
| pub struct ServiceFeeConfig { |
There was a problem hiding this comment.
I think we were considering doing vecs for denom, register_fee, and resume_fee so we could whitelist more registration denoms in the future. I'm okay with leaving it the current way to keep things simple for now
There was a problem hiding this comment.
I can its safer to just accept neutron at starter, and then move to a better design if needed.
uditvira
approved these changes
Feb 23, 2024
…e raw fold)
* fixed all executeable (execute, migrate) msgs types to remove "string" msgs and not are using "object" msgs (added {} to empty msgs)
this is needed because the CLI automatically try to parse those to json, for some reason the cli works differently for queries in that regard.
* added global min_amount for auctions, so each auctions looks at the min_amount it must have before starting an auction.
* added migrate msgs and entry points to all contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the audit fixes as well as other fixes and some changes.