Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cdc.sql #861

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update cdc.sql #861

wants to merge 2 commits into from

Conversation

sarwarbhuiyan
Copy link
Collaborator

We do need the before returned so as to be able to do "undo" in the changelog query processing

PR checklist:

  • Did you run ClangFormat ?
  • Did you separate headers to a different section in existing community code base ?
  • Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:

We do need the before returned so as to be able to do "undo" in the changelog query processing
@sarwarbhuiyan
Copy link
Collaborator Author

@jovezhong this is the better one since it includes the undo capability

Copy link
Contributor

@jovezhong jovezhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably a typo for type converting. Also please change the format to make the script more compact.

examples/cdc/cdc.sql Outdated Show resolved Hide resolved
examples/cdc/cdc.sql Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants