-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
listen for 0.0.0.0 instead 127.1 by default #814
Merged
yokofly
merged 4 commits into
develop
from
feature/issue-813-listen-for-all-ipv4-by-default
Aug 8, 2024
Merged
listen for 0.0.0.0 instead 127.1 by default #814
yokofly
merged 4 commits into
develop
from
feature/issue-813-listen-for-all-ipv4-by-default
Aug 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jovezhong
approved these changes
Aug 8, 2024
|
…ecover-two-level-global-aggr]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please write user-readable short description of the changes:
fix #813
below is my mac device output for this pr
./proton-server
start log: we can connect with./proton-client
, keep the ipv6 still
what is the impact?
for example I am using python driver to connect to another server proton-server(binary start with ./proton-server),
for now, this can be directly connected, previous I need edit conf and restart. (same sub-network)
but the docker side already supported/work, this pr only make the binary default listen host changed a bit.