Skip to content

Commit

Permalink
ignore warnings in clang-18
Browse files Browse the repository at this point in the history
  • Loading branch information
what-is-me committed Nov 23, 2024
1 parent 82ff10c commit 7ee3a38
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@
url = https://github.com/ClickHouse-Extras/NuRaft.git
[submodule "contrib/datasketches-cpp"]
path = contrib/datasketches-cpp
url = https://github.com/ClickHouse-Extras/datasketches-cpp.git
url = https://github.com/apache/datasketches-cpp.git
[submodule "contrib/yaml-cpp"]
path = contrib/yaml-cpp
url = https://github.com/ClickHouse-Extras/yaml-cpp.git
Expand Down
4 changes: 4 additions & 0 deletions cmake/warnings.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,9 @@ if (COMPILER_CLANG)
no_warning(thread-safety-negative) # experimental flag, too many false positives
no_warning(enum-constexpr-conversion) # breaks magic-enum library in clang-16
no_warning(unsafe-buffer-usage) # too aggressive
no_warning(switch-default) # conflicts with "defaults in a switch covering all enum values" in clang-18
no_warning(deprecated-declarations) # conflicts with "type is deprecated" in clang-18
no_warning(missing-field-initializers) # conflicts with "missing field initializer" in clang-18
no_warning(thread-safety-reference-return) # conflicts with "returning variable by reference requires holding mutex exclusively" in clang-18
# TODO Enable conversion, sign-conversion, double-promotion warnings.
endif ()
2 changes: 1 addition & 1 deletion contrib/datasketches-cpp
Submodule datasketches-cpp updated 287 files

0 comments on commit 7ee3a38

Please sign in to comment.