Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] support passing extra args to kind create #362

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DerekTBrown
Copy link

What does this PR do?

  • Allows passing arbitrary extra arguments to kind. This is useful for several debugging scenarios and edge cases, described in the kind_extra_args.yaml file I included.

@DerekTBrown DerekTBrown force-pushed the derektbrown_feat_kind_extra_args branch from 24ba04a to 4a24cad Compare October 16, 2024 17:39
@nicks
Copy link
Member

nicks commented Oct 19, 2024

thanks for the contribution!

high-level question - the docs say "Extra command line arguments passed to Kind CLI" -- but then you only pass arguments to kind create, not other kind cli invocations (e.g., kind delete). And your docs are mixing up create-specific flags with global flags. I'm not sure how to resolve this though?

@nicks nicks self-requested a review October 19, 2024 20:57
@DerekTBrown DerekTBrown changed the title [feat] support passing extra args to kind [feat] support passing extra args to kind create Oct 22, 2024
@DerekTBrown
Copy link
Author

DerekTBrown commented Oct 22, 2024

high-level question - the docs say "Extra command line arguments passed to Kind CLI" -- but then you only pass arguments to kind create, not other kind cli invocations (e.g., kind delete). And your docs are mixing up create-specific flags with global flags. I'm not sure how to resolve this though?

That's a good call out! At least for my purposes, I only need to pass CLI flags to kind create. I can rename the property accordingly.

Before I refactor: does this data model make sense to you, or should I be thinking about a more generic interface (I could imagine that other providers would want to have a similar interface)?

@nicks
Copy link
Member

nicks commented Oct 22, 2024

ya, i'd be fine if it was KindCreateExtraArguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants