tso/local: remove dc location and local_locator.go #8851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
ti-chi-bot
bot
added
release-note-none
Signed-off-by: okJiang <[email protected]>
okJiang
force-pushed
the
local-tso-svr-3
branch
from
d862594
to
460faf4
Compare
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8851 +/- ##
==========================================
+ Coverage 75.86% 76.11% +0.24%
==========================================
Files 460 458 -2
Lines 70637 70167 -470
==========================================
- Hits 53591 53408 -183
+ Misses 13673 13394 -279
+ Partials 3373 3365 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/cc @JmPotato |
rleungx
approved these changes
Nov 27, 2024
lhy1024
approved these changes
Nov 29, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/retest |
niubell
approved these changes
Nov 29, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, niubell, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Ref #8802
What is changed and how does it work?
Check List
Tests
Release note