Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tso: remove local tso code part 2 #8846

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Nov 22, 2024

What problem does this PR solve?

Issue Number: Ref #8802

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.77%. Comparing base (ec77762) to head (ba2e850).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8846      +/-   ##
==========================================
+ Coverage   75.19%   75.77%   +0.58%     
==========================================
  Files         459      460       +1     
  Lines       71299    70693     -606     
==========================================
- Hits        53616    53571      -45     
+ Misses      14266    13747     -519     
+ Partials     3417     3375      -42     
Flag Coverage Δ
unittests 75.77% <25.00%> (+0.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

Signed-off-by: okJiang <[email protected]>
@okJiang okJiang changed the title tso: remove local tso part code tso: remove local tso code part 1 Nov 22, 2024
@okJiang okJiang changed the title tso: remove local tso code part 1 tso: remove local tso code part 2 Nov 22, 2024
errors.toml Outdated
error = '''
set local tso config failed, %s
'''

["PD:tso:ErrSyncMaxTS"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me remove it

Signed-off-by: okJiang <[email protected]>
@okJiang
Copy link
Member Author

okJiang commented Nov 22, 2024

/retest

}
return nil
}

// GetClusterDCLocationsFromEtcd fetches dcLocation topology from etcd
func (am *AllocatorManager) GetClusterDCLocationsFromEtcd() (clusterDCLocations map[string][]uint64, err error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not delete all the functions; it is already large enough. We just need to ensure that the deleted content does not affect normal operation. The remaining functions will be removed in subsequent PRs.

go am.ClusterDCLocationChecker()
return nil
}

// GetClusterDCLocations returns all dc-locations of a cluster with a copy of map,
// which satisfies dcLocation -> DCLocationInfo.
func (am *AllocatorManager) GetClusterDCLocations() map[string]DCLocationInfo {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 25, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 25, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-25 02:47:18.09903673 +0000 UTC m=+431825.718691241: ☑️ agreed by rleungx.
  • 2024-11-25 06:54:14.303793061 +0000 UTC m=+446641.923447577: ☑️ agreed by JmPotato.

Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, niubell, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 25, 2024
@okJiang
Copy link
Member Author

okJiang commented Nov 25, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 21a04cb into tikv:master Nov 25, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants