-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tso: remove local tso code part 2 #8846
Conversation
Signed-off-by: okJiang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8846 +/- ##
==========================================
+ Coverage 75.19% 75.77% +0.58%
==========================================
Files 459 460 +1
Lines 71299 70693 -606
==========================================
- Hits 53616 53571 -45
+ Misses 14266 13747 -519
+ Partials 3417 3375 -42
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: okJiang <[email protected]>
errors.toml
Outdated
error = ''' | ||
set local tso config failed, %s | ||
''' | ||
|
||
["PD:tso:ErrSyncMaxTS"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me remove it
Signed-off-by: okJiang <[email protected]>
/retest |
} | ||
return nil | ||
} | ||
|
||
// GetClusterDCLocationsFromEtcd fetches dcLocation topology from etcd | ||
func (am *AllocatorManager) GetClusterDCLocationsFromEtcd() (clusterDCLocations map[string][]uint64, err error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does not delete all the functions; it is already large enough. We just need to ensure that the deleted content does not affect normal operation. The remaining functions will be removed in subsequent PRs.
go am.ClusterDCLocationChecker() | ||
return nil | ||
} | ||
|
||
// GetClusterDCLocations returns all dc-locations of a cluster with a copy of map, | ||
// which satisfies dcLocation -> DCLocationInfo. | ||
func (am *AllocatorManager) GetClusterDCLocations() map[string]DCLocationInfo { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato, niubell, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What problem does this PR solve?
Issue Number: Ref #8802
What is changed and how does it work?
Check List
Tests
Release note