Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: independent the service discovery package #8825

Merged
merged 5 commits into from
Nov 25, 2024
Merged

*: independent the service discovery package #8825

merged 5 commits into from
Nov 25, 2024

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #8690.

What is changed and how does it work?

Make the service discovery module of the client a separate package.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added the component/client Client logic. label Nov 19, 2024
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 19, 2024
@JmPotato
Copy link
Member Author

/cc @rleungx @okJiang @lhy1024 PTAL

@ti-chi-bot ti-chi-bot bot requested review from rleungx and lhy1024 November 19, 2024 07:45
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

@JmPotato: GitHub didn't allow me to request PR reviews from the following users: okJiang, PTAL.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @rleungx @okJiang @lhy1024 PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 75.29%. Comparing base (be4a366) to head (cfef0be).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8825      +/-   ##
==========================================
+ Coverage   75.24%   75.29%   +0.05%     
==========================================
  Files         458      459       +1     
  Lines       71300    71299       -1     
==========================================
+ Hits        53650    53688      +38     
+ Misses      14236    14213      -23     
+ Partials     3414     3398      -16
Flag Coverage Δ
unittests 75.29% <87.50%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@okJiang
Copy link
Member

okJiang commented Nov 19, 2024

/retest

okJiang
okJiang reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

client/sd/mock_pd_service_discovery.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 20, 2024
@JmPotato JmPotato force-pushed the service_discovery branch 3 times, most recently from 4f5462e to 550240f Compare November 22, 2024 06:51
rleungx
rleungx reviewed Nov 25, 2024
View reviewed changes
client/utils/mics.go Outdated
// See the License for the specific language governing permissions and
// limitations under the License.

package utils
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about renaming to constant?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used a constants dictionary to place them. PTAL.

@JmPotato JmPotato force-pushed the service_discovery branch 2 times, most recently from c2b5d9e to 5afb182 Compare November 25, 2024 03:24
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 25, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 25, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-20 07:45:13.13037284 +0000 UTC m=+17700.750027351: ☑️ agreed by okJiang.
  • 2024-11-25 03:43:23.818340062 +0000 UTC m=+435191.437994578: ☑️ agreed by rleungx.

@JmPotato
Copy link
Member Author

/test pull-integration-realcluster-test

@ti-chi-bot ti-chi-bot bot merged commit ec77762 into tikv:master Nov 25, 2024
25 checks passed
@JmPotato JmPotato deleted the service_discovery branch November 25, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@okJiang okJiang okJiang approved these changes

@lhy1024 lhy1024 Awaiting requested review from lhy1024

Assignees
No one assigned
Labels
approved component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JmPotato @okJiang @rleungx