Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to validate read ts for all RPC requests #1513

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Try to validate read ts for all RPC requests #1513

wants to merge 7 commits into from

Conversation

MyonKeminta
Copy link
Contributor

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from myonkeminta, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 4, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 4, 2024
@MyonKeminta
Add tests
1806599 
Signed-off-by: MyonKeminta <[email protected]>
@MyonKeminta MyonKeminta marked this pull request as ready for review December 4, 2024 09:57
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2024
cfzjywxk
cfzjywxk reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

oracle/oracles/pd.go
return nil
}

latestTSInfo, exists := o.getLastTSWithArrivalTS(opt.TxnScope)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the txnScope related check and map structure within this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk left review comments

@zyguan zyguan Awaiting requested review from zyguan

@you06 you06 Awaiting requested review from you06

@crazycs520 crazycs520 Awaiting requested review from crazycs520

@ekexium ekexium Awaiting requested review from ekexium

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MyonKeminta @cfzjywxk