Allow configuring the policy when prewrite encounters lock #1501
+32
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ekexium <[email protected]>
…unter-lock-policy
ti-chi-bot
bot
added
dco-signoff: yes
ekexium
force-pushed
the
prewrite-encounter-lock-policy
branch
from
08b47b2 to
8ce525d
Compare
Signed-off-by: ekexium <[email protected]>
ekexium
force-pushed
the
prewrite-encounter-lock-policy
branch
from
8ce525d to
fa81972
Compare
|
The comparison data between this PR and master in description is same, is there a typo? |
Oops. Updated. |
you06
approved these changes
Nov 25, 2024
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: you06 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cfzjywxk
reviewed
Nov 25, 2024
| TryResolvePolicy PrewriteEncounterLockPolicy = iota | ||
| // NoResolvePolicy means do not resolve, but return write conflict errors directly. | ||
| // This can be used to let the upper layer choose to retry in pessimistic mode. | ||
| NoResolvePolicy |
There was a problem hiding this comment.
What is the specific design for using the policy at the upper layer? Is it that autocommit optimistic transactions use NoResolvePolicy while everything else remains unchanged?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR allows the upper layer to control what to do when prewrite encounters lock. A typical usage is for TiDB optimistic autocommit transactions in high-contention scenarios. TiDB will retry the statement in pessimistic mode, so an error can be directly returned to save the effort of backoff, improving efficiency and latency.
A sysbench update_non_index with pareto distribution shows the difference:
If we choose to skip resolving locks when prewrite encounters locks
Master (try resolving locks)