Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lidar_centerpoint): reintroduce voxel order from front #1745

Conversation

technolojin
Copy link

Description

reimplementation of PR #1688

AWF implementation autowarefoundation#9608
with fix of voxel index bug

@knzo25 said

ポイント: point.x=76.799995
rangeのfiltert突破するけど
floorf((point.x - min_x_range + pillar_x_size) / pillar_x_size) - 1;
でも480になる
-> floorfの実装おかしい?

 (76.799995 + 76.800003 + 0.32) / 0.32 - 1
479.99999375

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

YoshiRi and others added 2 commits December 26, 2024 11:39
…erpoint/voxel-fill-from-front

feat: optimize voxel indexing in preprocess_kernel.cu
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
@technolojin technolojin self-assigned this Dec 26, 2024
@technolojin technolojin marked this pull request as ready for review December 26, 2024 02:44
Copy link

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@technolojin technolojin merged commit 60efdcc into tier4:beta/x2_gen2/v0.29.0 Dec 26, 2024
19 of 21 checks passed
@technolojin technolojin deleted the v0.29.0/centerpoint/voxel-order-with-fix branch December 26, 2024 03:03
@knzo25
Copy link

knzo25 commented Dec 26, 2024

Just in case, I will leave the related slack's thread here:
https://star4.slack.com/archives/C03S84LDJGG/p1735181112627609?thread_ts=1735120284.924819&cid=C03S84LDJGG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants