fix(pid_longitudinal_controller): fix overrun distance calculation against goal position #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuki-takagi-66 <[email protected]>
yuki-takagi-66
requested review from
soblin,
TakaHoribe and
takayuki5168
as code owners
|
TomohitoAndo
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
autowarefoundation#4712 により、goalに対してオーバーランした際に、オーバーラン距離が0になってしまうバグが混入していました。
この問題のhotfixし、オーバーラン距離を取得できるようにします。
Related links
awfでの修正
autowarefoundation#9685
3.1への修正
#1713
related confluence page:
https://tier4.atlassian.net/wiki/spaces/~382034962/pages/3479405302/v4.0.1
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.