Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motion_velocity_smoother): make stopping_distance and stopping_velocity be able to work (#6037) #1341

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Jun 19, 2024

Description

autowarefoundation#6037 のbackport
engage_velocity適用判定で使用するstop_distの計算において、経路終端が0になっているのが前提だが0になっておらずdouble::max()が常に出力されていたのを修正

const double stop_dist = trajectory_utils::calcStopDistance(input_traj, input_closest);

Related links

https://tier4.atlassian.net/browse/VEH-1001

Tests performed

psimにおいて、engage_velocity適用判定で使用するstop_distをデバッグコードを仕込んで出力できるようにし、正常な値が計算されていることを確認した
また、これまで停止際にengage_velocityが入力されていたが、入力されないことも確認した

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta merged commit d6f95ed into beta/v0.18.1 Jun 19, 2024
18 checks passed
@h-ohta h-ohta deleted the backport/6037 branch June 19, 2024 05:38
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants