Fixed gg_season() not correctly wrapping across facet_period

tidyverts · May 12, 2024 · 0d285e7 · 0d285e7
1 parent 51d8e27
commit 0d285e7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # feasts (development version)
 
+* Fixed `gg_season()` not wrapping across `facet_period` argument correctly.
+
 # feasts 0.3.2
 
 Minor patch to resolve CRAN check issues with ggplot2 v3.5.0 breaking changes.

diff --git a/R/graphics.R b/R/graphics.R
@@ -40,7 +40,7 @@ time_identifier <- function(idx, period, base = NULL, within = NULL, interval){
   grps <- floor_tsibble_date(idx, period)
 
   facet_grps <- if(!is.null(within)){
-    time_identifier(idx, period = within, base = period, interval = interval)$id
+    time_identifier(time_offset_origin(floor_tsibble_date(idx, period), within), period = period, base = period, interval = period)$id
   } else {
     rep_along(idx, FALSE)
   }