-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to {cli} in check_args() functions #1093
Conversation
This PR converts existing checks to {cli}, expanded checking will be tracked with #1095 |
Todo: make sure we allow zero length input in input checking as per #1099 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so happy you did this! These are a huge improvement.
I'm going to leave a "Comment" review to indicate that I'd like to take another look and re-review after you work through review comments, just because there are so many lines affected and cli markup mistakes can hard to spot visually on the first try. I'm around and interruptable today, so re-review should come quick. :)
Co-authored-by: Simon P. Couch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
STELLAR
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Ref: #1081
Now the call are being passed around, such as it is being emitted from
fit()
which feels appropriate. I wonder is there is a way to signal the model as well? so instead of sayingError in fit():
it says something likeError in fit() for discrim_linear():
or something to that liking. It would be nice for workflowsetsAlso, I didn't detect any tests 😬 so I'll add those as well
Extension packages:
check_args()
rules#83check_args()
discrim#67check_args()
baguette#75check_args()
plsmod#38check_args()
poissonreg#83check_args()
censored#314Empty tests
Some of the tests are left intentionally empty, this is either because there is a placeholder
check_args()
method with no checking, or no method at all. All missing methods will be handled by #1094