changes for #15 (#16)

tidymodels · Oct 23, 2024 · f42b705 · f42b705
1 parent c57e0ad
commit f42b705
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 7 deletions.
diff --git a/R/checks.R b/R/checks.R
@@ -1,6 +1,6 @@
-check_numeric <- function(x, input = "`x`", call = rlang::caller_env()) {
+check_numeric <- function(x, input = "x", call = rlang::caller_env()) {
   if (!is.vector(x) || !is.numeric(x)) {
-    cli::cli_abort("{.arg {input}} should be {an} numeric vector.")
+    cli::cli_abort("{.arg {input}} should be a numeric vector.")
   }
   invisible(NULL)
 }

diff --git a/tests/testthat/_snaps/in-line.md b/tests/testthat/_snaps/in-line.md
@@ -302,3 +302,19 @@
       Error in `d_category()`:
       ! Desirability values should be numeric and complete in the range [0, 1].
 
+---
+
+    Code
+      d_min(letters, 1, 2)
+    Condition
+      Error in `check_numeric()`:
+      ! `x` should be a numeric vector.
+
+---
+
+    Code
+      d_min(letters[1], 1, 2)
+    Condition
+      Error in `check_numeric()`:
+      ! `x` should be a numeric vector.
+
diff --git a/tests/testthat/test-in-line.R b/tests/testthat/test-in-line.R
@@ -133,6 +133,11 @@ test_that('correct values', {
   oob[1] <- 10
   expect_snapshot(d_category(month.abb[2:4], oob), error = TRUE)
 
+  # ------------------------------------------------------------------------------
+
+  expect_snapshot(d_min(letters, 1, 2), error = TRUE)
+  expect_snapshot(d_min(letters[1], 1, 2), error = TRUE)
+
 })
 
 test_that('missing values', {

diff --git a/tests/testthat/test-overall.R b/tests/testthat/test-overall.R
@@ -1,9 +1,4 @@
 
-test_that('tolerance values', {
-
-
-})
-
 test_that('overall desirability computations', {
 
   expect_equal(