Don't assume that 127.0.0.[2-255] aren't in use. #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A pair of tests were testing error paths for non-responsive hosts. To do so, they were attempting to connect to 127.0.0.2 and 127.0.0.3. However, some hosts are configured to respond to 127.0.0.0/8 as localhost, and with such a configuration, these tests could fail. One alternative is to configure mongodb to bind specifically to 127.0.0.1. Another would be a test helper that tests the expected IP to make sure nothing responds before running the test, possibly skipping it if something responds (or trying another address?) But this solution seems like the simplest, easiest change to make, that covers the most possible configurations.
ewollesen
force-pushed
the
eric/localhost
branch
from
87967c4
to
a719c16
Compare
toddkazakov
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pair of tests were testing error paths for non-responsive hosts. To do so, they were attempting to connect to 127.0.0.2 and 127.0.0.3. However, some hosts are configured to respond to 127.0.0.0/8 as localhost, and with such a configuration, these tests could fail.
One alternative is to configure mongodb to bind specifically to 127.0.0.1. Another would be a test helper that tests the expected IP to make sure nothing responds before running the test, possibly skipping it if something responds (or trying another address?) But this solution seems like the simplest, easiest change to make, that covers the most possible configurations.