[BACK-43] jellyfish updates based on reuse of legacy _id for migration #203
Conversation
jh-bate
changed the title
|
/deploy qa3 |
|
jh-bate updated values.yaml file in qa3 |
|
jh-bate updated flux policies file in qa3 |
|
jh-bate deployed jellyfish add-dedup-hash branch to qa3 namespace |
|
/deploy qa3 |
|
jh-bate updated values.yaml file in qa3 |
|
jh-bate updated flux policies file in qa3 |
|
jh-bate deployed jellyfish add-dedup-hash branch to qa3 namespace |
|
/deploy qa3 |
|
jh-bate updated values.yaml file in qa3 |
|
jh-bate updated flux policies file in qa3 |
|
jh-bate deployed jellyfish add-dedup-hash branch to qa3 namespace |
|
/deploy qa3 |
|
jh-bate updated values.yaml file in qa3 |
|
jh-bate updated flux policies file in qa3 |
|
jh-bate deployed jellyfish add-dedup-hash branch to qa3 namespace |
|
/deploy qa3 |
|
jh-bate updated values.yaml file in qa3 |
|
jh-bate updated flux policies file in qa3 |
|
jh-bate deployed jellyfish add-dedup-hash branch to qa3 namespace |
|
/deploy qa3 |
|
jh-bate updated values.yaml file in qa3 |
|
jh-bate updated flux policies file in qa3 |
|
jh-bate deployed jellyfish add-dedup-hash branch to qa3 namespace |
There was a problem hiding this comment.
LGTM. One comment on a bit of simplification, if you so choose.
Also, there are a number of outstanding vulnerabilities (npm audit, snyk, dependabot). I ran my usual update process and created a new PR on top of this one. You can either merge into this PR or cherry pick it. The PR is #205.
lib/schema/qa3_user_ids.json
Outdated
| @@ -0,0 +1 @@ | |||
| [] | |||
There was a problem hiding this comment.
You might as well go ahead and check in similar files for all the environments. That way if this is deployed anywhere it will still function, but effectively act the same and use Jellyfish.
lib/misc.js
Outdated
| var iv = `${env}-environment`.substring(0, 16); | ||
| var key = serverSecret.substring(0, 32); | ||
| var algorithm = 'aes-256-cbc'; |
There was a problem hiding this comment.
[nit] Consider pulling these out into a separate function so we guarantee that encryption and decryption use the same values.
lib/misc.js
Outdated
| var key = serverSecret.substring(0, 32); | ||
| var algorithm = 'aes-256-cbc'; | ||
|
|
||
| var encryptedArray = dataArray.map((item) => { |
There was a problem hiding this comment.
Ah, so you are encrypting each user id separately, not just the entire file?
lib/misc.js
Outdated
| @@ -65,3 +65,35 @@ exports.generateId = function(fields) { | |||
| return base32hex.encodeBuffer(hasher.digest(), { paddingChar: '-' }); | |||
| }; | |||
|
|
|||
| exports.encryptArrayToFile = function (dataArray, filePath, env, serverSecret) { | |||
There was a problem hiding this comment.
How do we use this when creating/updating the unencrypted file?
* userid hash for platform users
see tidepool-org/development#297