[WIP][LOOP-5153] Remove HealthKit dependency from LoopAlgorithm #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Camji55
commented
Nov 22, 2024
| @@ -63,11 +62,11 @@ final class WatchContext: RawRepresentable { | |||
| isClosedLoop = rawValue["cl"] as? Bool | |||
|
|
|||
| if let unitString = rawValue["gu"] as? String { | |||
| displayGlucoseUnit = HKUnit(from: unitString) | |||
| displayGlucoseUnit = LoopUnit(from: unitString) | |||
There was a problem hiding this comment.
I will verify this -- not 100% this will work with mmol/L
Camji55
commented
Nov 22, 2024
| @@ -126,7 +125,15 @@ final class WatchContext: RawRepresentable { | |||
| raw["gc"] = glucoseCondition?.rawValue | |||
| raw["gt"] = glucoseTrend?.rawValue | |||
| if let glucoseTrendRate = glucoseTrendRate { | |||
| let unitPerMinute = unit.unitDivided(by: .minute()) | |||
| let unitPerMinute: LoopUnit | |||
There was a problem hiding this comment.
I need to verify if this needed
Camji55
commented
Nov 22, 2024
| @@ -111,11 +111,21 @@ class StatusWidgetTimelineProvider: TimelineProvider { | |||
| } | |||
|
|
|||
| let finalGlucose = glucose | |||
|
|
|||
| let unit: LoopUnit? | |||
| switch await healthStore.cachedPreferredUnits(for: .bloodGlucose) { | |||
There was a problem hiding this comment.
I need to verify if needed
Camji55
commented
Nov 22, 2024
| @@ -298,7 +298,17 @@ class LoopAppManager: NSObject { | |||
| } | |||
|
|
|||
| Task { @MainActor in | |||
| if let unit = await self.healthStore.cachedPreferredUnits(for: .bloodGlucose) { | |||
| var unit: LoopUnit? | |||
| switch await self.healthStore.cachedPreferredUnits(for: .bloodGlucose) { | |||
There was a problem hiding this comment.
I need to verify if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tidepool.atlassian.net/browse/LOOP-5153