Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct screen size detection #51

Merged
merged 1 commit into from
Feb 13, 2014
Merged

Correct screen size detection #51

merged 1 commit into from
Feb 13, 2014

Conversation

kreijack
Copy link
Contributor

The XRandR api was used in a such way to get the DEFAULT size instead the
current one. This patch create a helper function (detect_display_size()) which
detects the current size of the screen; it is called both in the
GuiCalibratorX11() constructor and in the redraw() method.

How reproduce the problem:

  1. compile xinput for X11 ( autogen.sh --with-gui=x11)
  2. change the resolution to a not default one (like xrandr -s 640x480)
  3. start xinput_calibrator
  4. the result is a window size equal to the size of the DEFAULT resolution of the screen, and not the current one
  5. expected result: a window size equal to the size of the CURRENT resolution of the screen

The XRandR api was used in a such way to get the *DEFAULT* size instead the
corrent one. This patch create a helper function (detect_display_size()) which
detects the current size of the screen; it  is called both in the
GuiCalibratorX11() constructor and in the redraw() method.
@vvjcarter
Copy link

I second the pull request, experiencing the same problem as reported in issue #53

tias added a commit that referenced this pull request Feb 13, 2014
Correct screen size detection
@tias tias merged commit 03dadf5 into tias:master Feb 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants