Fix geostrophic balance for open box #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue #12 by not imposing zero velocity on the boundary. The flow spins up to a steady geostrophic state as I initially expected.
w3168
changed the title
After chatting with Stephan if specifying a bc id don't add the boundary integral twice on outflows! There is a slight subtletly with the previous else option fo specifying uin. It only set a u value of zero in the momentum advection term. It doesnt set u in the continuity equation. This might be useful as a stabilising term (for instance in the overturning.py script with the open top) but it is not obvious that it makes physical sense because if you specify a stress bc then the velocity can be nonzero
Probably linked to firedrakeproject/firedrake#3288 where sparsity pattern has changed
Don't repeat all the same code from the runscript just to change one bc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #12 by not imposing zero velocity on the boundary. The flow spins up to a steady geostrophic state as I initially expected.
The velocity components min/max at 10 days are
[-0.010000631499020347, -0.009999197635247136], [-6.696454717473091e-7, 5.16239883303038e-7], [-5.489538266305904e-9, 5.105960664779745e-9]