Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load entity types and add cache tags and contexts in search api producer #857

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

ol0lll
Copy link
Member

@ol0lll ol0lll commented Dec 9, 2024

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.
  • New features or changes are documented.

If you are really awesome, then your feature is covered by additional tests. Well done!

Copy link
Member

@dbosen dbosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add tests similar to EntitiesWithTermTest::testQueryCacheMetadata()

@ol0lll ol0lll temporarily deployed to thunder-pr-857 December 12, 2024 11:05 Inactive
dbosen
dbosen previously approved these changes Dec 18, 2024
@chrfritsch chrfritsch changed the base branch from 7.3.x to 7.4.x December 18, 2024 12:39
@chrfritsch chrfritsch dismissed dbosen’s stale review December 18, 2024 12:39

The base branch was changed.

@chrfritsch chrfritsch merged commit 4120888 into 7.4.x Dec 18, 2024
12 checks passed
@chrfritsch chrfritsch deleted the fix/search-api-on-graphql-caching branch December 18, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants