Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove responsive_preview module #814

Merged
merged 6 commits into from
Jul 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ jobs:
composer remove thunder/thunder-distribution --no-update
composer config name "drupal-testing-thunder/thunder-distribution" --working-dir="${GITHUB_WORKSPACE}"
composer require "drupal-testing-thunder/thunder-distribution:*" --no-update
composer require "drupal/responsive_preview" --no-update
composer require "drupal/slick:^2.7" --no-update
composer require "drupal/blazy:^2.14" --no-update
composer require "drupal/core-dev:~10.3.0" --no-update
Expand Down
2 changes: 0 additions & 2 deletions config/install/user.role.editor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ dependencies:
- media
- node
- path
- responsive_preview
- scheduler
- system
- taxonomy
Expand All @@ -37,7 +36,6 @@ permissions:
- 'access contextual links'
- 'access files overview'
- 'access media overview'
- 'access responsive preview'
- 'access tokens overview'
- 'access toolbar'
- 'administer menu'
Expand Down
2 changes: 0 additions & 2 deletions config/install/user.role.restricted_editor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ dependencies:
- media
- node
- path
- responsive_preview
- scheduler
- system
- taxonomy
Expand All @@ -35,7 +34,6 @@ permissions:
- 'access contextual links'
- 'access files overview'
- 'access media overview'
- 'access responsive preview'
- 'access tokens overview'
- 'access toolbar'
- 'break content lock'
Expand Down
2 changes: 0 additions & 2 deletions config/install/user.role.seo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ dependencies:
- node
- path
- redirect
- responsive_preview
- scheduler
- system
- taxonomy
Expand All @@ -40,7 +39,6 @@ permissions:
- 'access contextual links'
- 'access files overview'
- 'access media overview'
- 'access responsive preview'
- 'access tokens overview'
- 'access toolbar'
- 'administer menu'
Expand Down
6 changes: 3 additions & 3 deletions docs/developer-guide/migration/migrate-7-8.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ drush updb
You should at least see the Thunder XXXX schema update. If not, double check that the correct version of Thunder
is installed, and that `drush updb` did not throw any errors.

Before you start with the code and database update please add the Slick module and the
Blazy module to your own composer.json. Both are no longer part of Thunder and can be removed after the update
Before you start with the code and database update please add the Slick module, the Blazy module and the Responsive
Preview module to your own composer.json. Both are no longer part of Thunder and can be removed after the update
was successfully executed.

```bash
composer require drupal/blazy drupal/slick
composer require drupal/blazy drupal/slick drupal/responsive_preview
```

Also, if you have jquery_ui, jquery_ui_draggable or default_content enabled, you have to
Expand Down
4 changes: 0 additions & 4 deletions docs/user-guide/feature-overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,6 @@ system that uses tokens which the administrator can change.\
**Redirect**: The Redirect module automatically adds redirects if the URL of an article has been changed.\
[https://www.drupal.org/project/redirect](https://www.drupal.org/project/redirect)

**Responsive Preview**: The Responsive Preview module provides editors with a quick way to preview how their site's
pages will appear at narrow and wide width dimensions on different devices.\
[https://www.drupal.org/project/responsive_preview](https://www.drupal.org/project/responsive_preview)

**Scheduler**: Scheduler gives content editors the ability to schedule nodes to be published and unpublished at
specified dates and times in the future. Dates can be entered either as plain text or with calendar popups.\
[https://www.drupal.org/project/scheduler](https://www.drupal.org/project/scheduler)
Expand Down
5 changes: 0 additions & 5 deletions phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -175,11 +175,6 @@ parameters:
count: 6
path: tests/src/FunctionalJavascript/Integration/ParagraphsPasteTest.php

-
message: "#^Call to an undefined method Drupal\\\\Tests\\\\WebAssert\\:\\:waitForElement\\(\\)\\.$#"
count: 1
path: tests/src/FunctionalJavascript/Integration/ResponsivePreviewTest.php

-
message: "#^Call to an undefined method Drupal\\\\Tests\\\\WebAssert\\:\\:waitForElementVisible\\(\\)\\.$#"
count: 5
Expand Down
1 change: 0 additions & 1 deletion tests/src/Functional/ModuleUninstallTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ class ModuleUninstallTest extends ThunderTestBase {
['diff'],
['content_lock'],
['access_unpublished'],
['responsive_preview'],
['length_indicator'],
['redirect'],
['simple_sitemap'],
Expand Down
104 changes: 0 additions & 104 deletions tests/src/FunctionalJavascript/Integration/ResponsivePreviewTest.php

This file was deleted.

1 change: 0 additions & 1 deletion thunder.info.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ install:
- schema_metatag:schema_article
- select2:select2
- simple_sitemap:simple_sitemap
- responsive_preview:responsive_preview
- update_helper_checklist:update_helper_checklist
- views_bulk_edit:views_bulk_edit
# thunder
Expand Down
Loading