Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove orphan form helper #802

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Remove orphan form helper #802

merged 3 commits into from
Jun 24, 2024

Conversation

ol0lll
Copy link
Member

@ol0lll ol0lll commented Jun 3, 2024

Remove zombie ThunderNodeFormHelper reintroduced in #688

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.
  • New features or changes are documented.

If you are really awesome, then your feature is covered by additional tests. Well done!

@ol0lll ol0lll temporarily deployed to thunder-pr-802 June 3, 2024 15:15 Inactive
@chrfritsch chrfritsch changed the base branch from 7.2.x to 7.3.x June 24, 2024 08:56
@chrfritsch chrfritsch merged commit f5d3be3 into 7.3.x Jun 24, 2024
11 checks passed
@chrfritsch chrfritsch deleted the remove-orphan-form-helper branch June 24, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants