Skip to content

Commit

Permalink
Remove thunders custom steps
Browse files Browse the repository at this point in the history
  • Loading branch information
alexpott committed Jan 10, 2024
1 parent b0fca79 commit 0e0ea8f
Show file tree
Hide file tree
Showing 2 changed files with 47 additions and 46 deletions.
49 changes: 25 additions & 24 deletions tests/src/Functional/Installer/ThunderInstallerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,30 +41,31 @@ protected function setUpProfile(): void {
// This step is skipped, because there is a distribution profile.
}

/**
* Final installer step: Configure site.
*/
protected function setUpSite(): void {
$edit = $this->translatePostValues($this->parameters['forms']['install_configure_form']);
$edit['enable_update_status_module'] = FALSE;
$edit['enable_update_status_emails'] = FALSE;
$this->submitForm($edit, $this->translations['Save and continue']);
dump($this->getSession()->getPage()->getContent());
// If we've got to this point the site is installed using the regular
// installation workflow.
$this->setUpModules();
}

/**
* Setup modules -> subroutine of test setUp process.
*/
protected function setUpModules(): void {
// @todo Add another test that tests interactive install of all optional
// Thunder modules.
$this->submitForm([], $this->translations['Save and continue']);
dump($this->getSession()->getPage()->getContent());
$this->isInstalled = TRUE;
}
// /**

Check failure on line 44 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L44 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:44:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)

Check failure on line 44 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L44 <Drupal.Commenting.InlineComment.SpacingBefore>

2 spaces found before inline comment; expected "// /**" but found "// /**"
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:44:1: error: 2 spaces found before inline comment; expected "// /**" but found "//  /**" (Drupal.Commenting.InlineComment.SpacingBefore)
// * Final installer step: Configure site.

Check failure on line 45 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L45 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:45:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)

Check failure on line 45 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L45 <Drupal.Commenting.InlineComment.SpacingBefore>

Comment indentation error, expected only 2 spaces
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:45:1: error: Comment indentation error, expected only 2 spaces (Drupal.Commenting.InlineComment.SpacingBefore)
// */

Check failure on line 46 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L46 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:46:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// protected function setUpSite(): void {

Check failure on line 47 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L47 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:47:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// $edit = $this->translatePostValues($this->parameters['forms']['install_configure_form']);

Check failure on line 48 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L48 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:48:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)

Check failure on line 48 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L48 <Drupal.Commenting.InlineComment.SpacingBefore>

Comment indentation error, expected only 2 spaces
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:48:1: error: Comment indentation error, expected only 2 spaces (Drupal.Commenting.InlineComment.SpacingBefore)
// $edit['enable_update_status_module'] = FALSE;

Check failure on line 49 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L49 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:49:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// $edit['enable_update_status_emails'] = FALSE;

Check failure on line 50 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L50 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:50:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// $this->submitForm($edit, $this->translations['Save and continue']);

Check failure on line 51 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L51 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:51:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// dump($this->getSession()->getPage()->getContent());

Check failure on line 52 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L52 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:52:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// // If we've got to this point the site is installed using the regular

Check failure on line 53 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L53 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:53:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// // installation workflow.

Check failure on line 54 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L54 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:54:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// //$this->setUpModules();

Check failure on line 55 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L55 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:55:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// $this->isInstalled = TRUE;

Check failure on line 56 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L56 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:56:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// }

Check failure on line 57 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L57 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:57:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
//

Check failure on line 58 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L58 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:58:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// /**

Check failure on line 59 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L59 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:59:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// * Setup modules -> subroutine of test setUp process.

Check failure on line 60 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L60 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:60:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)

Check failure on line 60 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L60 <Drupal.Commenting.InlineComment.SpacingBefore>

Comment indentation error, expected only 2 spaces
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:60:1: error: Comment indentation error, expected only 2 spaces (Drupal.Commenting.InlineComment.SpacingBefore)
// */

Check failure on line 61 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L61 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:61:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// protected function setUpModules(): void {

Check failure on line 62 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L62 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:62:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// // @todo Add another test that tests interactive install of all optional

Check failure on line 63 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L63 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:63:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)

Check failure on line 63 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L63 <Drupal.Commenting.InlineComment.SpacingBefore>

Comment indentation error, expected only 2 spaces
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:63:1: error: Comment indentation error, expected only 2 spaces (Drupal.Commenting.InlineComment.SpacingBefore)
// // Thunder modules.

Check failure on line 64 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L64 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:64:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// $this->submitForm([], $this->translations['Save and continue']);

Check failure on line 65 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L65 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:65:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// dump($this->getSession()->getPage()->getContent());

Check failure on line 66 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L66 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:66:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// $this->isInstalled = TRUE;

Check failure on line 67 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L67 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:67:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)
// }

Check failure on line 68 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] tests/src/Functional/Installer/ThunderInstallerTest.php#L68 <Drupal.WhiteSpace.ScopeIndent.IncorrectExact>

Line indented incorrectly; expected 2 spaces, found 0
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:68:1: error: Line indented incorrectly; expected 2 spaces, found 0 (Drupal.WhiteSpace.ScopeIndent.IncorrectExact)

Check warning on line 68 in tests/src/Functional/Installer/ThunderInstallerTest.php

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal practice)

[drupal-coder (drupal practice)] tests/src/Functional/Installer/ThunderInstallerTest.php#L68 <DrupalPractice.Commenting.CommentEmptyLine.SpacingAfter>

There must be no blank line following an inline comment
Raw output
/github/workspace/tests/src/Functional/Installer/ThunderInstallerTest.php:68:1: warning: There must be no blank line following an inline comment (DrupalPractice.Commenting.CommentEmptyLine.SpacingAfter)

/**
* Confirms that the installation succeeded.
Expand Down
44 changes: 22 additions & 22 deletions thunder.profile
Original file line number Diff line number Diff line change
Expand Up @@ -22,28 +22,28 @@ function thunder_form_install_configure_form_alter(array &$form, FormStateInterf
$form['site_information']['site_name']['#placeholder'] = t('Thunder');
}

/**
* Implements hook_install_tasks().
*/
function thunder_install_tasks(array &$install_state): array {
$tasks = [];
if (empty($install_state['config_install_path'])) {
$tasks['thunder_module_configure_form'] = [
'display_name' => t('Configure additional modules'),
'type' => 'form',
'function' => ModuleConfigureForm::class,
];
$tasks['thunder_module_install'] = [
'display_name' => t('Install additional modules'),
'type' => 'batch',
'run' => empty($install_state['thunder_install_batch']) ? INSTALL_TASK_SKIP : INSTALL_TASK_RUN_IF_NOT_COMPLETED,
];
}
$tasks['thunder_finish_installation'] = [
'display_name' => t('Finish installation'),
];
return $tasks;
}
///**

Check failure on line 25 in thunder.profile

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] thunder.profile#L25 <Drupal.Commenting.InlineComment.NoSpaceBefore>

No space found before comment text; expected "// /**" but found "///**"
Raw output
/github/workspace/thunder.profile:25:1: error: No space found before comment text; expected "// /**" but found "///**" (Drupal.Commenting.InlineComment.NoSpaceBefore)
// * Implements hook_install_tasks().
// */
//function thunder_install_tasks(array &$install_state): array {

Check failure on line 28 in thunder.profile

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] thunder.profile#L28 <Drupal.Commenting.InlineComment.NoSpaceBefore>

No space found before comment text; expected "// function thunder_install_tasks(array &$install_state): array {" but found "//function thunder_install_tasks(array &$install_state): array {"
Raw output
/github/workspace/thunder.profile:28:1: error: No space found before comment text; expected "// function thunder_install_tasks(array &$install_state): array {" but found "//function thunder_install_tasks(array &$install_state): array {" (Drupal.Commenting.InlineComment.NoSpaceBefore)
// $tasks = [];
// if (empty($install_state['config_install_path'])) {
// $tasks['thunder_module_configure_form'] = [

Check failure on line 31 in thunder.profile

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] thunder.profile#L31 <Drupal.Commenting.InlineComment.SpacingBefore>

Comment indentation error, expected only 2 spaces
Raw output
/github/workspace/thunder.profile:31:1: error: Comment indentation error, expected only 2 spaces (Drupal.Commenting.InlineComment.SpacingBefore)
// 'display_name' => t('Configure additional modules'),

Check failure on line 32 in thunder.profile

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] thunder.profile#L32 <Drupal.Commenting.InlineComment.SpacingBefore>

Comment indentation error, expected only 4 spaces
Raw output
/github/workspace/thunder.profile:32:1: error: Comment indentation error, expected only 4 spaces (Drupal.Commenting.InlineComment.SpacingBefore)
// 'type' => 'form',
// 'function' => ModuleConfigureForm::class,
// ];
// $tasks['thunder_module_install'] = [
// 'display_name' => t('Install additional modules'),

Check failure on line 37 in thunder.profile

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] thunder.profile#L37 <Drupal.Commenting.InlineComment.SpacingBefore>

Comment indentation error, expected only 4 spaces
Raw output
/github/workspace/thunder.profile:37:1: error: Comment indentation error, expected only 4 spaces (Drupal.Commenting.InlineComment.SpacingBefore)
// 'type' => 'batch',
// 'run' => empty($install_state['thunder_install_batch']) ? INSTALL_TASK_SKIP : INSTALL_TASK_RUN_IF_NOT_COMPLETED,

Check warning on line 39 in thunder.profile

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] thunder.profile#L39 <Drupal.Files.LineLength.TooLong>

Line exceeds 80 characters; contains 120 characters
Raw output
/github/workspace/thunder.profile:39:1: warning: Line exceeds 80 characters; contains 120 characters (Drupal.Files.LineLength.TooLong)
// ];
// }
// $tasks['thunder_finish_installation'] = [
// 'display_name' => t('Finish installation'),

Check failure on line 43 in thunder.profile

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] thunder.profile#L43 <Drupal.Commenting.InlineComment.SpacingBefore>

Comment indentation error, expected only 2 spaces
Raw output
/github/workspace/thunder.profile:43:1: error: Comment indentation error, expected only 2 spaces (Drupal.Commenting.InlineComment.SpacingBefore)
// ];
// return $tasks;
//}

Check failure on line 46 in thunder.profile

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal)

[drupal-coder (drupal)] thunder.profile#L46 <Drupal.Commenting.InlineComment.NoSpaceBefore>

No space found before comment text; expected "// }" but found "//}"
Raw output
/github/workspace/thunder.profile:46:1: error: No space found before comment text; expected "// }" but found "//}" (Drupal.Commenting.InlineComment.NoSpaceBefore)

Check warning on line 46 in thunder.profile

View workflow job for this annotation

GitHub Actions / drupal-coder (drupal practice)

[drupal-coder (drupal practice)] thunder.profile#L46 <DrupalPractice.Commenting.CommentEmptyLine.SpacingAfter>

There must be no blank line following an inline comment
Raw output
/github/workspace/thunder.profile:46:1: warning: There must be no blank line following an inline comment (DrupalPractice.Commenting.CommentEmptyLine.SpacingAfter)

/**
* Installs the thunder modules in a batch.
Expand Down

0 comments on commit 0e0ea8f

Please sign in to comment.