widen black formatter (88 -> 100 chars) #97
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bennyguo this is a very simple way to enforce a non-default max width. I ran some quick tests with a relatively large font in vscode, 2 files side-by-side plus the bar on the left, and I recommend a value between 100 and 110.
The moment we merge this however, we might want to do a project-wide reformatting of the python files. If we don't, when someone pushes a commit, their actual change will be burried in tons of unrelated formatting changes. sigh. I volunteer to figure this out and do this right after the PR is merged, if you agree with this plan.
@thuliu-yt16 @voletiv FYI. If you have large outstanding changes, I recommend you merge them before we do this.