Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize JvmArgs #272

Open
The-File opened this issue Aug 27, 2023 · 2 comments
Open

Sanitize JvmArgs #272

The-File opened this issue Aug 27, 2023 · 2 comments

Comments

@The-File
Copy link

Apparently some threerings products are using jvm arguments that are not valid in more recent java versions.

One notorious instance being the "-XX:+AggressiveOpts" arguments used by getdown to launch Spiral Knights with. This throws an error for recent versions of the JVM.

As per official citation of its removal - https://bugs.openjdk.org/browse/JDK-8150552

@bekoenig
Copy link
Contributor

Hi,
we have the same issue with other JVM arguments. A simple solution was to set "-XX:+IgnoreUnrecognizedVMOptions" in the getdown.txr.
I think this is a good default to avoid problems on further JVM upgrades.
Greetings,
Ben

@The-File
Copy link
Author

Thanks ben, I'll check with deploying the "-XX:+IgnoreUnrecognizedVMOptions" runtime argument in an extra.txt file rather than modifying the getdown.jar to mangle interpreting the getdown.txt itself to avoid "-XX:+AggressiveOpts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants