Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knight Launcher Compatibility #2

Open
The-File opened this issue Aug 29, 2023 · 3 comments
Open

Knight Launcher Compatibility #2

The-File opened this issue Aug 29, 2023 · 3 comments

Comments

@The-File
Copy link
Owner

Currently, because we require a custom set of getdown jars and an extra.txt that requires modification as a direct result of such, this breaks third party launchers that only base themselves on running decade old java versions.

@The-File
Copy link
Owner Author

As per a recommendation in threerings/getdown#272

If we add "-XX:+IgnoreUnrecognizedVMOptions" to extra.txt we should be able to outright delete the getdown patches entirely, and remove the following block of text in extra.txt...

"-Djava.library.path=%APPDIR%/native
-Dorg.lwjgl.util.NoChecks=true
-Dsun.java2d.d3d=false
-Dappdir=%APPDIR%
-Dresource_dir=%APPDIR%/rsrc"

That text block is necessary because the getdown jar patch specifically knocks out reading a portion of getdown.txt.

@The-File
Copy link
Owner Author

It would still be required of KL to redistribute the latest set of DLLs and their accompanying jars from the last official LWJGL 2 build, as per Java 9 will not run due to JNI compatibility issues with the slightly older set Spiral Knights is distributed with by default.

As per the readme:
"Update the supporting OpenAL and JInput JNI files (.dll, .so, .dylib) to the latest versions found bundled with LWJGL 2.9.3. Additionally, the file jinput.jar under the code directory as well needs replacement."

@The-File
Copy link
Owner Author

88c56df

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant