Use current version of inline-style-prefixer #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This crosses the v5.0.0 version, which required some changes to the import paths. All tests still pass. It turns out crossing this threshold is important for us, because we depend on libraries that depend on post-5.0.0 versions of inline-style-prefixer, and the two versions are incompatible. Node resolves this by allowing multiple versions of a single package in the same project. But we're running this code in browsers, and we're constrained to using a bundler that also doesn't support multiple versions. So if we can bump this library to use a post-5.0.0 version, all uses will be compatible.
|
Sorry I haven't been on this project for a while, but this seems like a worthy update. Give me a few days and I'll get this in. |
kyptin
added a commit
to kyptin/shadow-cljs-example-breakage
that referenced
this pull request
Jun 2, 2021
(See previous commit message for context.) First, we fixed glamor to work with the current version (post-v5) of inline-style-prefixer (ISP). For full details on those changes, see this PR we opened: threepointone/glamor#396 After that, we: - cloned that (forked) version of glamor to vendor/glamor, - ran `npm install` in that directory, - ran `npm run build` in that directory to compile the source and make library paths available, and - removed unneeded files with `rm -rf .git node_modules`. Finally, we added two new dependencies to our project: - glamor, pointing to the vendored code, and - ISP at ^6.0.0, which at this point both ui-box and (our local version of) glamor can use without a problem. (For some reason we don't yet understand, only adding glamor wasn't enough. When we did that, ISP wasn't getting installed at the top level of node_modules, and Shadow CLJS wasn't able to find it, so we had to add it as a top-level dep.) After that and a top-level `npm install`, we could `npm run watch` and have a working example that used a previously broken feature of Evergreen. Credit: Christopher Gsell for pair programming me on this journey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crosses the v5.0.0 version, which required some changes to the import paths. All tests still pass.
It turns out crossing this threshold is important for us, because we depend on libraries that depend on post-5.0.0 versions of inline-style-prefixer, and the two versions are incompatible. Node resolves this by allowing multiple versions of a single package in the same project. But we're running this code in browsers, and we're constrained to using a bundler that doesn't support multiple versions. So if we can bump this library to use a post-5.0.0 version, all uses will be compatible.