Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up host keys before first boot #2138

Merged
merged 9 commits into from
Nov 30, 2023
Merged

Conversation

Eslam-Nawara
Copy link
Contributor

Description

remove host keys on vm run

Related Issues

pkg/vm/manager.go Outdated Show resolved Hide resolved
Copy link
Member

@muhamadazmy muhamadazmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is completely wrong, please check comments

pkg/primitives/vm/utils.go Outdated Show resolved Hide resolved
pkg/primitives/vm/utils.go Outdated Show resolved Hide resolved
pkg/primitives/vm/utils.go Outdated Show resolved Hide resolved
pkg/primitives/vm/utils.go Outdated Show resolved Hide resolved
pkg/primitives/vm/utils.go Outdated Show resolved Hide resolved
pkg/primitives/vm/utils.go Outdated Show resolved Hide resolved
go.mod Outdated
@@ -70,6 +70,7 @@ require (
github.com/coreos/go-iptables v0.6.0 // indirect
github.com/cosmos/go-bip39 v1.0.0 // indirect
github.com/cpuguy83/go-md2man/v2 v2.0.2 // indirect
github.com/dave/jennifer v1.3.0 // indirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that was added? Please remove.

go.sum Outdated
@@ -106,6 +106,7 @@ github.com/d2g/dhcp4 v0.0.0-20170904100407-a1d1b6c41b1c/go.mod h1:Ct2BUK8SB0YC1S
github.com/d2g/dhcp4client v1.0.0/go.mod h1:j0hNfjhrt2SxUOw55nL0ATM/z4Yt3t2Kd1mW34z5W5s=
github.com/d2g/dhcp4server v0.0.0-20181031114812-7d4a0a7f59a5/go.mod h1:Eo87+Kg/IX2hfWJfwxMzLyuSZyxSoAug2nGa1G2QAi8=
github.com/d2g/hardwareaddr v0.0.0-20190221164911-e7d9fbe030e4/go.mod h1:bMl4RjIciD2oAxI7DmWRx6gbeqrkoLqv3MV0vzNad+I=
github.com/dave/jennifer v1.3.0 h1:p3tl41zjjCZTNBytMwrUuiAnherNUZktlhPTKoF/sEk=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That of course as well

Copy link
Member

@muhamadazmy muhamadazmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@muhamadazmy muhamadazmy merged commit 7e2e347 into main Nov 30, 2023
23 checks passed
@muhamadazmy muhamadazmy deleted the clean-up-host-vm-keys branch November 30, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants