Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve VM detection #2105

Merged
merged 2 commits into from
Nov 14, 2023
Merged

improve VM detection #2105

merged 2 commits into from
Nov 14, 2023

Conversation

Eslam-Nawara
Copy link
Contributor

muhamadazmy
muhamadazmy requested changes Nov 13, 2023
View reviewed changes
Copy link
Member

@muhamadazmy muhamadazmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please forma the code properly. and make the formatter part of the editor save routine

@muhamadazmy muhamadazmy merged commit 9cb513e into main Nov 14, 2023
23 checks passed
@muhamadazmy muhamadazmy deleted the improve_vm_detection branch November 14, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhamadazmy muhamadazmy muhamadazmy approved these changes

@delandtj delandtj Awaiting requested review from delandtj

@MarioBassem MarioBassem Awaiting requested review from MarioBassem

@ashraffouda ashraffouda Awaiting requested review from ashraffouda ashraffouda is a code owner

@rawdaGastan rawdaGastan Awaiting requested review from rawdaGastan rawdaGastan is a code owner

@xmonader xmonader Awaiting requested review from xmonader xmonader is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eslam-Nawara @muhamadazmy