Move zos-update-worker to zos/tools #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eslam-Nawara
requested review from
muhamadazmy,
delandtj,
MarioBassem,
ashraffouda,
rawdaGastan and
xmonader
as code owners
|
This dragged too many unrelated files e.g .gitignore in subdirectories, update_codewners files?all the go mods need to be reviewed , Makefile, Taskfile, .. etc all should be integrated within zos repo |
xmonader
requested changes
Oct 22, 2023
muhamadazmy
requested changes
Nov 7, 2023
Comment on lines
119
to
124
| zosCurrent := fmt.Sprintf("%v/%v", w.src, currentZosVersion) | ||
| zosLatest := fmt.Sprintf("%v/%v", w.dst, network) | ||
| // the link is like zosCurrent but it has the path relative from the symlink | ||
| // point of view (so relative to the symlink, how to reach zosCurrent) | ||
| // hence the link is instead used in all calls to symlink | ||
| link := fmt.Sprintf("%v/%v", path, currentZosVersion) |
There was a problem hiding this comment.
according to the issue here #2099 the currentZosVersoin should always be of format .tag-<version>
Eslam-Nawara
force-pushed
the
move_zos-update-worker_to_zos/tools
branch
6 times, most recently
from
6cb9014 to
abfd3a1
Compare
Eslam-Nawara
force-pushed
the
move_zos-update-worker_to_zos/tools
branch
from
abfd3a1 to
9c1367c
Compare
muhamadazmy
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move zos-update-worker to zos/tools
Related Issues
zos-update-workerto use new style of zos release #2099